Repository navigation
feat: thread xp through Grid2DIrregular.grid_2d_via_deflection_grid_from - #414
Merged
Merged
Conversation
Removes the known JAX-jit blocker for the PyAutoLens point-source source-plane fit path (PyAutoLabs/PyAutoLens#657, phase 2). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ubtraction xp=None now defaults to self._xp (pre-existing behaviour preserved for JAX-backed callers not passing xp); deflection_grid unwrapped via .array so traced values never hit __array__/asarray (verified: the source-plane vmap+jit regression now passes where it raised TracerArrayConversionError). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an explicit
xp=npparameter toGrid2DIrregular.grid_2d_via_deflection_grid_from, propagated like the sibling methods (subtracted_from,distances_to_coordinate_from) already do. This was the known JAX-jit blocker for the PyAutoLens point-source source-plane fit path (FitPositionsSourceand the new solved-centre variants), which calls this method under trace. Part of the point-source likelihood-variants series (PyAutoLabs/PyAutoLens#657, phase 2 of 5).API Changes
Added an optional
xp=npkeyword to one public method — fully backwards compatible (default preserves current behaviour).See full details below.
Test Plan
pytest test_autoarray/(906 passed locally)pytest test_autolens/point/on the paired PyAutoLens branch (85 passed locally)Full API Changes (for automation & release notes)
Changed Signature
Grid2DIrregular.grid_2d_via_deflection_grid_from(deflection_grid)→grid_2d_via_deflection_grid_from(deflection_grid, xp=np)— optional, default unchanged.Companion PRs: PyAutoGalaxy + PyAutoLens branches
feature/point-source-chi-squared-variants. Merge this first.Generated by the PyAutoLabs agent workflow.